<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">So the idea behind this commit is that dynamic timeslosts should count when calculating total available load, even if they are at pdch at that moment, because they can be turned to TCH at any time when required. Am I correct? please describe something like that in the commit message.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Yes, correct - see the updated comments in the new patch. From the CS perspective, there is no difference whether this is a dynamic TS in NONE/PDCH mode or a static TCH in UNUSED mode since BSC can switch into USED mode at any moment.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18090">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18090/1/src/osmo-bsc/chan_alloc.c">File src/osmo-bsc/chan_alloc.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18090/1/src/osmo-bsc/chan_alloc.c@40">Patch Set #1, Line 40:</a> <code style="font-family:monospace,monospace">void bts_chan_load(struct pchan_load *cl, const struct gsm_bts *bts)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">would be great having documentation for this function...</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'll commit a one-liner in a separate commit.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18090/1/src/osmo-bsc/chan_alloc.c@63">Patch Set #1, Line 63:</a> <code style="font-family:monospace,monospace"> * have an lchan's allocated to them */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">"an lchan allocated"</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18090/1/src/osmo-bsc/chan_alloc.c@66">Patch Set #1, Line 66:</a> <code style="font-family:monospace,monospace"> && ( ts->pchan_is == GSM_PCHAN_NONE</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">please fix whitespace in all this if condition.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I'm not completely sure of the Osmocom rules for the muli-line whitespace but I've changed this to look closer to what I see around in the next revision of this patch.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18090/1/src/osmo-bsc/chan_alloc.c@72">Patch Set #1, Line 72:</a> <code style="font-family:monospace,monospace"> * Note: When GSM_PCHAN_TCH_F_TCH_H_PDCH is allocation</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">"is allocation in" doesn't make sense to me, please fix. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/18090">change 18090</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/18090"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iabd70e8adbf15eb3b7a7be597281ea99b352317b </div>
<div style="display:none"> Gerrit-Change-Number: 18090 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 07 May 2020 12:36:53 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>