Change in osmo-bsc[master]: stats: Add a stats gauge for the MSC link status.

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18092 )

Change subject: stats: Add a stats gauge for the MSC link status.
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/c/osmo-bsc/+/18092/1/include/osmocom/bsc/gsm_data.h 
File include/osmocom/bsc/gsm_data.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/18092/1/include/osmocom/bsc/gsm_data.h@1557 
PS1, Line 1557: enum {
can we have a name for this enum? for the sake of being able to refer to it. Everybody deserves having a name! :)


https://gerrit.osmocom.org/c/osmo-bsc/+/18092/1/include/osmocom/bsc/gsm_data.h@1588 
PS1, Line 1588: 	struct osmo_stat_item_group *bsc_statg;
worth adding a comment on top explaining what's used for now that you are adding it.


https://gerrit.osmocom.org/c/osmo-bsc/+/18092/1/src/osmo-bsc/a_reset.c 
File src/osmo-bsc/a_reset.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/18092/1/src/osmo-bsc/a_reset.c@75 
PS1, Line 75: 	LOGPFSML(fi, LOGL_NOTICE, "SIGTRAN connection succeeded.\n");
Ugh, why do we have a connection successed on a "disc" (disconnect?" callback?


https://gerrit.osmocom.org/c/osmo-bsc/+/18092/1/src/osmo-bsc/bsc_init.c 
File src/osmo-bsc/bsc_init.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/18092/1/src/osmo-bsc/bsc_init.c@48 
PS1, Line 48: 	{ "msc_link", "MSC link status.", "", 16, 0 },
Do we add dots at the end of descriptions? probably not (please check).
Last param is a pointer, so NULL fits better.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18092
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ibe4b29056ba704a27b925cfdba49f343ee34f428
Gerrit-Change-Number: 18092
Gerrit-PatchSet: 1
Gerrit-Owner: ipse <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 07 May 2020 10:59:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200507/3e6c8089/attachment.htm>