Change in libosmo-abis[master]: lapd: Always print context information when logging

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon May 4 11:06:14 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/18003 )

Change subject: lapd: Always print context information when logging
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/libosmo-abis/+/18003/1/include/osmocom/abis/lapd.h 
File include/osmocom/abis/lapd.h:

https://gerrit.osmocom.org/c/libosmo-abis/+/18003/1/include/osmocom/abis/lapd.h@68 
PS1, Line 68: OSMO_DEPRECATED
> Do we really need to deprecate this function just because of a new feature? I mean this is not a bug […]
I understand your line of thought.  But in the end, we want to make sure that all users set a proper name, so we get the most useful log information (with context).  By simply adding a new function, we risk that users/callers don't update their code, as they won't even get a warning. So my preference remains to use the current approach.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/18003
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Ib81a749ae24013b17caaf5fd64ccd9acbbc3ce08
Gerrit-Change-Number: 18003
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Mon, 04 May 2020 11:06:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200504/89fa6c28/attachment.htm>


More information about the gerrit-log mailing list