Change in osmo-bts[master]: Ensure we include lchan name in all LAPDm log lines

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat May 2 19:36:38 UTC 2020


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/18004 )


Change subject: Ensure we include lchan name in all LAPDm log lines
......................................................................

Ensure we include lchan name in all LAPDm log lines

This makes use of the newly-introduced lapdm_channel_init3() API,
which provides the user (BTS in this case) to provide a human-readable
string identifier for each LAPDm channel.  This identifier is
subsequently used in all related log lines to provide context.

This means we will now get context information about which specific
SAPI in which sub-channel (ACCH/DCCH) on which lchan/ts/trx/bts a given
message originated from.

Change-Id: I17e3d4797ec71e31d0775330ae36d2e1fd70423f
Depends: libosmocore.git Ie6742843fff809edffcac24c4dce4edf66bc71be
Related: OS#1938
---
M src/common/bts.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/04/18004/1

diff --git a/src/common/bts.c b/src/common/bts.c
index 2200615..9710a2c 100644
--- a/src/common/bts.c
+++ b/src/common/bts.c
@@ -429,7 +429,8 @@
 			  "Setting T200 D0=%u, D3=%u, S0=%u, S3=%u (all in ms)\n",
 			  t200_ms_dcch[DL_SAPI0], t200_ms_dcch[DL_SAPI3],
 			  t200_ms_acch[DL_SAPI0], t200_ms_acch[DL_SAPI3]);
-		lapdm_channel_init2(lc, LAPDM_MODE_BTS, t200_ms_dcch, t200_ms_acch, lchan->type);
+		lapdm_channel_init3(lc, LAPDM_MODE_BTS, t200_ms_dcch, t200_ms_acch, lchan->type,
+				    gsm_lchan_name(lchan));
 		lapdm_channel_set_flags(lc, LAPDM_ENT_F_POLLING_ONLY);
 		lapdm_channel_set_l1(lc, NULL, lchan);
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18004
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I17e3d4797ec71e31d0775330ae36d2e1fd70423f
Gerrit-Change-Number: 18004
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200502/2aaaf4ef/attachment.htm>


More information about the gerrit-log mailing list