Change in osmo-ttcn3-hacks[master]: library/GSM_RR_Types.ttcn: fix: work around TITAN bug 562488

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17994 )

Change subject: library/GSM_RR_Types.ttcn: fix: work around TITAN bug 562488
......................................................................

library/GSM_RR_Types.ttcn: fix: work around TITAN bug 562488

Commit [1] introduced multiple regressions, because it basically
changed the byte order in all fields of the whole module from
'first' (implicit default) to 'last'. This is not what we need.

Instead, let's apply BYTEORDER(last) to 5 bit 'ext_ra' fields
unless the bug [2] in TITAN's RAW codec is fixed.

[1] I481a40daef3eed4a3daa687ad87c4128a13181b4
[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=562488

Change-Id: If998ef72c13787f04fee79e1e646cd9a6787028a
Signed-off-by: Vadim Yanitskiy <axilirator at gmail.com>
---
M library/GSM_RR_Types.ttcn
1 file changed, 6 insertions(+), 5 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index 6e359ab..dcf12ae 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -194,10 +194,7 @@
 	type record LocationAreaIdentification {
 		BcdMccMnc	mcc_mnc,
 		uint16_t	lac
-	} with {
-		/* Otherwise '262F45'H is encoded as '24F262'H */
-		variant (mcc_mnc) "BYTEORDER(first)"
-	};
+	} with { variant "" };
 
 	/* TS 24.008 10.5.1.4 */
 	type enumerated MobileIdentityType {
@@ -412,6 +409,8 @@
 		variant (r99) "CSN.1 L/H"
 		variant (presence) "PRESENCE(r99 = '1'B)" /* H */
 		variant (ext_ra) "PRESENCE(presence = '1'B)"
+		/* See https://bugs.eclipse.org/bugs/show_bug.cgi?id=562488 */
+		variant (ext_ra) "BYTEORDER(last)" // FIXME: should be first
 	};
 	type union PacketUlDlAssignUnion {
 		PacketUlAssign		ul,
@@ -634,6 +633,8 @@
 		variant (ats)	"PRESENCE(ats_present = '1'B)"
 		variant (dynamic)	"PRESENCE(presence = '1'B)"
 		variant (multiblock)	"PRESENCE(presence = '0'B)"
+		/* See https://bugs.eclipse.org/bugs/show_bug.cgi?id=562488 */
+		variant (ext_ra) "BYTEORDER(last)" // FIXME: should be first
 	};
 
 	type octetstring MblkDlAss;	/* TODO */
@@ -1064,4 +1065,4 @@
 		}
 	};
 
-} with { encode "RAW" ; variant "FIELDORDER(msb)" variant "BYTEORDER(last)" }
+} with { encode "RAW" ; variant "FIELDORDER(msb)" }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17994
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If998ef72c13787f04fee79e1e646cd9a6787028a
Gerrit-Change-Number: 17994
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200502/78d48274/attachment.htm>