<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17994">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/GSM_RR_Types.ttcn: fix: work around TITAN bug 562488<br><br>Commit [1] introduced multiple regressions, because it basically<br>changed the byte order in all fields of the whole module from<br>'first' (implicit default) to 'last'. This is not what we need.<br><br>Instead, let's apply BYTEORDER(last) to 5 bit 'ext_ra' fields<br>unless the bug [2] in TITAN's RAW codec is fixed.<br><br>[1] I481a40daef3eed4a3daa687ad87c4128a13181b4<br>[2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=562488<br><br>Change-Id: If998ef72c13787f04fee79e1e646cd9a6787028a<br>Signed-off-by: Vadim Yanitskiy <axilirator@gmail.com><br>---<br>M library/GSM_RR_Types.ttcn<br>1 file changed, 6 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn</span><br><span>index 6e359ab..dcf12ae 100644</span><br><span>--- a/library/GSM_RR_Types.ttcn</span><br><span>+++ b/library/GSM_RR_Types.ttcn</span><br><span>@@ -194,10 +194,7 @@</span><br><span> type record LocationAreaIdentification {</span><br><span> BcdMccMnc mcc_mnc,</span><br><span> uint16_t lac</span><br><span style="color: hsl(0, 100%, 40%);">- } with {</span><br><span style="color: hsl(0, 100%, 40%);">- /* Otherwise '262F45'H is encoded as '24F262'H */</span><br><span style="color: hsl(0, 100%, 40%);">- variant (mcc_mnc) "BYTEORDER(first)"</span><br><span style="color: hsl(0, 100%, 40%);">- };</span><br><span style="color: hsl(120, 100%, 40%);">+ } with { variant "" };</span><br><span> </span><br><span> /* TS 24.008 10.5.1.4 */</span><br><span> type enumerated MobileIdentityType {</span><br><span>@@ -412,6 +409,8 @@</span><br><span> variant (r99) "CSN.1 L/H"</span><br><span> variant (presence) "PRESENCE(r99 = '1'B)" /* H */</span><br><span> variant (ext_ra) "PRESENCE(presence = '1'B)"</span><br><span style="color: hsl(120, 100%, 40%);">+ /* See https://bugs.eclipse.org/bugs/show_bug.cgi?id=562488 */</span><br><span style="color: hsl(120, 100%, 40%);">+ variant (ext_ra) "BYTEORDER(last)" // FIXME: should be first</span><br><span> };</span><br><span> type union PacketUlDlAssignUnion {</span><br><span> PacketUlAssign ul,</span><br><span>@@ -634,6 +633,8 @@</span><br><span> variant (ats) "PRESENCE(ats_present = '1'B)"</span><br><span> variant (dynamic) "PRESENCE(presence = '1'B)"</span><br><span> variant (multiblock) "PRESENCE(presence = '0'B)"</span><br><span style="color: hsl(120, 100%, 40%);">+ /* See https://bugs.eclipse.org/bugs/show_bug.cgi?id=562488 */</span><br><span style="color: hsl(120, 100%, 40%);">+ variant (ext_ra) "BYTEORDER(last)" // FIXME: should be first</span><br><span> };</span><br><span> </span><br><span> type octetstring MblkDlAss; /* TODO */</span><br><span>@@ -1064,4 +1065,4 @@</span><br><span> }</span><br><span> };</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-} with { encode "RAW" ; variant "FIELDORDER(msb)" variant "BYTEORDER(last)" }</span><br><span style="color: hsl(120, 100%, 40%);">+} with { encode "RAW" ; variant "FIELDORDER(msb)" }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17994">change 17994</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17994"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If998ef72c13787f04fee79e1e646cd9a6787028a </div>
<div style="display:none"> Gerrit-Change-Number: 17994 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>