Change in pysim[master]: Move parsing of GID1 to generic Card class

[herlesupreeth]

herlesupreeth has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/17523 )

Change subject: Move parsing of GID1 to generic Card class
......................................................................

Move parsing of GID1 to generic Card class

Change-Id: Ie96408b1eecd6fc2595d619f6f0e3af851dacecb
---
M pySim-read.py
M pySim/cards.py
2 files changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/pySim-read.py b/pySim-read.py
index ed6cb29..083f91b 100755
--- a/pySim-read.py
+++ b/pySim-read.py
@@ -114,7 +114,7 @@
 
 	# EF.GID1
 	try:
-		(res, sw) = scc.read_binary(EF['GID1'])
+		(res, sw) = card.read_gid1()
 		if sw == '9000':
 			print("GID1: %s" % (res,))
 		else:
diff --git a/pySim/cards.py b/pySim/cards.py
index a43da9c..61a3707 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -145,6 +145,13 @@
 		data, sw = self._scc.update_binary(EF['SPN'], rpad(content, 32))
 		return sw
 
+	def read_gid1(self):
+		(res, sw) = self._scc.read_binary(EF['GID1'])
+		if sw == '9000':
+			return (res, sw)
+		else:
+			return (None, sw)
+
 	# Read the (full) AID for either ISIM or USIM application
 	def read_aid(self, isim = False):
 

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/17523
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie96408b1eecd6fc2595d619f6f0e3af851dacecb
Gerrit-Change-Number: 17523
Gerrit-PatchSet: 4
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200328/4402ddd7/attachment.htm>