<p>herlesupreeth <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/17523">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Move parsing of GID1 to generic Card class<br><br>Change-Id: Ie96408b1eecd6fc2595d619f6f0e3af851dacecb<br>---<br>M pySim-read.py<br>M pySim/cards.py<br>2 files changed, 8 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim-read.py b/pySim-read.py</span><br><span>index ed6cb29..083f91b 100755</span><br><span>--- a/pySim-read.py</span><br><span>+++ b/pySim-read.py</span><br><span>@@ -114,7 +114,7 @@</span><br><span> </span><br><span>      # EF.GID1</span><br><span>    try:</span><br><span style="color: hsl(0, 100%, 40%);">-            (res, sw) = scc.read_binary(EF['GID1'])</span><br><span style="color: hsl(120, 100%, 40%);">+               (res, sw) = card.read_gid1()</span><br><span>                 if sw == '9000':</span><br><span>                     print("GID1: %s" % (res,))</span><br><span>                 else:</span><br><span>diff --git a/pySim/cards.py b/pySim/cards.py</span><br><span>index a43da9c..61a3707 100644</span><br><span>--- a/pySim/cards.py</span><br><span>+++ b/pySim/cards.py</span><br><span>@@ -145,6 +145,13 @@</span><br><span>            data, sw = self._scc.update_binary(EF['SPN'], rpad(content, 32))</span><br><span>             return sw</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ def read_gid1(self):</span><br><span style="color: hsl(120, 100%, 40%);">+          (res, sw) = self._scc.read_binary(EF['GID1'])</span><br><span style="color: hsl(120, 100%, 40%);">+         if sw == '9000':</span><br><span style="color: hsl(120, 100%, 40%);">+                      return (res, sw)</span><br><span style="color: hsl(120, 100%, 40%);">+              else:</span><br><span style="color: hsl(120, 100%, 40%);">+                 return (None, sw)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>  # Read the (full) AID for either ISIM or USIM application</span><br><span>    def read_aid(self, isim = False):</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/17523">change 17523</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/17523"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie96408b1eecd6fc2595d619f6f0e3af851dacecb </div>
<div style="display:none"> Gerrit-Change-Number: 17523 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: herlesupreeth <herlesupreeth@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>