This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17617 ) Change subject: BSSGP: fix: properly encode P-TMSI in RR Paging Request ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/17617/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/17617/1/src/gprs_bssgp_pcu.cpp@173 PS1, Line 173: static uint8_t tmsi_buf[GSM48_TMSI_LEN]; > OSMO_ASSERT(GSM48_TMSI_LEN > GSM23003_TMSI_NUM_BYTES) GSM48_TMSI_LEN == GSM23003_TMSI_NUM_BYTES + 1, that's exactly what we need. https://gerrit.osmocom.org/c/osmo-pcu/+/17617/1/src/gprs_bssgp_pcu.cpp@180 PS1, Line 180: return BSSGP_CAUSE_COND_IE_ERR; > We could try harder to succeed by trying to return the IMSI instead (fine logging an error though of […] I also thought about that. But this can be done later. At the moment I don't see an easy way to do that (using goto?). https://gerrit.osmocom.org/c/osmo-pcu/+/17617/1/src/gprs_bssgp_pcu.cpp@185 PS1, Line 185: tmsi_buf[0] = 0xf0 | GSM_MI_TYPE_TMSI; > why is this 0xf0 needed? no define for it? In case of IMSI, this nibble is used for octet alignment. In case of TMSI it's unused and should be filled with '1'B. I think there is no define, because I copy-pasted it from libosmocore's osmo_mi_name_buf(). -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I97fd5ffc15a4a58112d7c37c69b7ac42b0741a0e Gerrit-Change-Number: 17617 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 26 Mar 2020 07:21:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200326/b6a9463f/attachment.htm>