This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17617 ) Change subject: BSSGP: fix: properly encode P-TMSI in RR Paging Request ...................................................................... Patch Set 1: Code-Review+1 (3 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/17617/1/src/gprs_bssgp_pcu.cpp File src/gprs_bssgp_pcu.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/17617/1/src/gprs_bssgp_pcu.cpp@173 PS1, Line 173: static uint8_t tmsi_buf[GSM48_TMSI_LEN]; OSMO_ASSERT(GSM48_TMSI_LEN > GSM23003_TMSI_NUM_BYTES) https://gerrit.osmocom.org/c/osmo-pcu/+/17617/1/src/gprs_bssgp_pcu.cpp@180 PS1, Line 180: return BSSGP_CAUSE_COND_IE_ERR; We could try harder to succeed by trying to return the IMSI instead (fine logging an error though of course). https://gerrit.osmocom.org/c/osmo-pcu/+/17617/1/src/gprs_bssgp_pcu.cpp@185 PS1, Line 185: tmsi_buf[0] = 0xf0 | GSM_MI_TYPE_TMSI; why is this 0xf0 needed? no define for it? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17617 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I97fd5ffc15a4a58112d7c37c69b7ac42b0741a0e Gerrit-Change-Number: 17617 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 25 Mar 2020 23:09:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200325/df0a9e00/attachment.htm>