Change in libosmocore[master]: gsm690: Fix amr speech bit length table

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

jfdionne gerrit-no-reply at lists.osmocom.org
Thu Mar 12 14:45:44 UTC 2020


jfdionne has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17470 )

Change subject: gsm690: Fix amr speech bit length table
......................................................................


Patch Set 1: Code-Review+1

> Patch Set 1:
> 
> Hello.
> 
> Please have a look at:  RFC 4867 §3.6, Table 1, Column "Total speech bits" 
> 
> I took all the numbers for Total speech bits and divided them by 8, they all match the table, except AMR SID. I have the feeling that it should be 5 bytes, not 7. I also can not find anything that would go into the additional 2 bytes.
> 
> Best regards.
> Philipp

Hi Philipp,

according to RFC 4867 you are right and AMR SID payload type length should be adjusted to 5 bytes.

Best regards,

Jean-Francois


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17470
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icf330450981b32be5d1cee5b10aa92bac4cb72f5
Gerrit-Change-Number: 17470
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jean-Francois Dionne <jf.dionne at nutaq.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: jfdionne <jf.dionne at nutaq.com>
Gerrit-Comment-Date: Thu, 12 Mar 2020 14:45:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200312/d4305623/attachment.htm>


More information about the gerrit-log mailing list