<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 1:</p><p style="white-space: pre-wrap; word-wrap: break-word;">Hello.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Please have a look at:  RFC 4867 §3.6, Table 1, Column "Total speech bits" </p><p style="white-space: pre-wrap; word-wrap: break-word;">I took all the numbers for Total speech bits and divided them by 8, they all match the table, except AMR SID. I have the feeling that it should be 5 bytes, not 7. I also can not find anything that would go into the additional 2 bytes.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Best regards.<br>Philipp</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Hi Philipp,</p><p style="white-space: pre-wrap; word-wrap: break-word;">according to RFC 4867 you are right and AMR SID payload type length should be adjusted to 5 bytes.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Best regards,</p><p style="white-space: pre-wrap; word-wrap: break-word;">Jean-Francois</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/17470">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/17470">change 17470</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/17470"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icf330450981b32be5d1cee5b10aa92bac4cb72f5 </div>
<div style="display:none"> Gerrit-Change-Number: 17470 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jean-Francois Dionne <jf.dionne@nutaq.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: jfdionne <jf.dionne@nutaq.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 12 Mar 2020 14:45:44 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>