This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17351 )
Change subject: trxcon/scheduler: refactor TDMA frame number calculation
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/c/osmocom-bb/+/17351/4/src/host/trxcon/sched_trx.c
File src/host/trxcon/sched_trx.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/17351/4/src/host/trxcon/sched_trx.c@750
PS4, Line 750: if (i + 1 == n)
> > [...] loop exits and "meas" is not used anymore. […]
Ah indeed, I didn't see it.
It probably makes sense to simplify the loop this way:
toa256_sum = meas->toa256;
rssi_sum = meas->rssi;
for (i = 0; i < n - 1; i++) { /* get back up to first burst */
if (meas == MEAS_HIST_FIRST(hist))
meas = MEAS_HIST_LAST(hist);
else
meas--;
toa256_sum += meas->toa256;
rssi_sum += meas->rssi;
}
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17351
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I9221957297a6154edc1767a0e3753f5ee383173f
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Mar 2020 11:02:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200311/a8f05087/attachment.htm>