<p>Patch set 5:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17351">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17351/4/src/host/trxcon/sched_trx.c">File src/host/trxcon/sched_trx.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17351/4/src/host/trxcon/sched_trx.c@750">Patch Set #4, Line 750:</a> <code style="font-family:monospace,monospace">           if (i + 1 == n)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">> [...] loop exits and "meas" is not used anymore. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ah indeed, I didn't see it.</p><p style="white-space: pre-wrap; word-wrap: break-word;">It probably makes sense to simplify the loop this way:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">toa256_sum = meas->toa256;<br>rssi_sum = meas->rssi;<br>for (i = 0; i < n - 1; i++) { /* get back up to first burst */<br>               if (meas == MEAS_HIST_FIRST(hist))<br>                    meas = MEAS_HIST_LAST(hist);<br>          else<br>                  meas--;<br>               toa256_sum += meas->toa256;<br>                rssi_sum += meas->rssi;<br>}</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/17351">change 17351</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/17351"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9221957297a6154edc1767a0e3753f5ee383173f </div>
<div style="display:none"> Gerrit-Change-Number: 17351 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 11 Mar 2020 11:02:28 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Comment-In-Reply-To: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>