Change in osmo-bts[master]: osmo-bts-virtual: Add "virtual-um ttl <0-255>" VTY option

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Mar 10 20:29:44 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17443 )

Change subject: osmo-bts-virtual: Add "virtual-um ttl <0-255>" VTY option
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/17443/2/src/osmo-bts-virtual/main.c 
File src/osmo-bts-virtual/main.c:

https://gerrit.osmocom.org/c/osmo-bts/+/17443/2/src/osmo-bts-virtual/main.c@126 
PS2, Line 126: 	plink->u.virt.ttl = -1;
> Worth adding here a comment with the -1 meaning. […]
relaly? Without checking I would say we hve tons of similar examples so far, but I can amend the commit if you like.


https://gerrit.osmocom.org/c/osmo-bts/+/17443/2/src/osmo-bts-virtual/virtualbts_vty.c 
File src/osmo-bts-virtual/virtualbts_vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/17443/2/src/osmo-bts-virtual/virtualbts_vty.c@178 
PS2, Line 178: ttl <0-255>
> There should be a way to set it back to -1. How about this? […]
there is no need for that, as changes are only permitted as long as the PHY link is shutdown, i.e. before it has started.  So I think there is no way to ever modify it back.  And even if you did, there is no setsockopt to un-set the TTL, so we'd have to close the socket and re-open it, ...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17443
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I18a9f93b764aee4e1dc68a1c6ac4d078e52ca61d
Gerrit-Change-Number: 17443
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 10 Mar 2020 20:29:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200310/0ffb8940/attachment.htm>


More information about the gerrit-log mailing list