This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17443 )
Change subject: osmo-bts-virtual: Add "virtual-um ttl <0-255>" VTY option
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/c/osmo-bts/+/17443/2/src/osmo-bts-virtual/virtual_um.c
File src/osmo-bts-virtual/virtual_um.c:
https://gerrit.osmocom.org/c/osmo-bts/+/17443/2/src/osmo-bts-virtual/virtual_um.c@83
PS2, Line 83: perror("Cannot set TTL of Virtual Um transmit socket");
> we should avoid perror but fine since I see we use it in other places in this file, a patch to fix a […]
ACK. LOGP statement with strerror(errno) should do the same.
https://gerrit.osmocom.org/c/osmo-bts/+/17443/2/src/osmo-bts-virtual/virtualbts_vty.c
File src/osmo-bts-virtual/virtualbts_vty.c:
https://gerrit.osmocom.org/c/osmo-bts/+/17443/2/src/osmo-bts-virtual/virtualbts_vty.c@178
PS2, Line 178: ttl <0-255>
There should be a way to set it back to -1. How about this?
"virtual-um ttl (default|<0-255>)"
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17443
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I18a9f93b764aee4e1dc68a1c6ac4d078e52ca61d
Gerrit-Change-Number: 17443
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 10 Mar 2020 18:42:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200310/8109d620/attachment.htm>