This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/17373 ) Change subject: bankd: Avoid useless dependency to libosmosim ...................................................................... bankd: Avoid useless dependency to libosmosim Change-Id: I015b1a49dbdd19d030acd929b5a935021b77cefa dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/osmo-remsim-bankd/usr/bin/osmo-remsim-bankd was not linked against libosmosim.so.0 (it uses none of the library's symbols) --- M src/bankd/Makefile.am M src/bankd/driver_pcsc.c M src/bankd/main.c 3 files changed, 2 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/bankd/Makefile.am b/src/bankd/Makefile.am index f2afa19..42c9bd3 100644 --- a/src/bankd/Makefile.am +++ b/src/bankd/Makefile.am @@ -1,6 +1,6 @@ AM_CFLAGS = -Wall -I$(top_srcdir)/include -I$(top_builddir)/include -I$(top_srcdir)/src \ -I$(top_srcdir)/include/osmocom/rspro \ - $(OSMOCORE_CFLAGS) $(OSMOGSM_CFLAGS) $(OSMOABIS_CFLAGS) $(OSMOSIM_CFLAGS) \ + $(OSMOCORE_CFLAGS) $(OSMOGSM_CFLAGS) $(OSMOABIS_CFLAGS) \ $(PCSC_CFLAGS) noinst_HEADERS = bankd.h internal.h @@ -14,7 +14,7 @@ osmo_remsim_bankd_SOURCES = ../slotmap.c ../rspro_client_fsm.c ../debug.c \ bankd_main.c bankd_pcsc.c -osmo_remsim_bankd_LDADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOABIS_LIBS) $(OSMOSIM_LIBS) \ +osmo_remsim_bankd_LDADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOABIS_LIBS) \ $(PCSC_LIBS) $(CSV_LIBS) $(top_builddir)/src/libosmo-rspro.la # as suggested in http://lists.gnu.org/archive/html/automake/2009-03/msg00011.html diff --git a/src/bankd/driver_pcsc.c b/src/bankd/driver_pcsc.c index 5102512..03a7f32 100644 --- a/src/bankd/driver_pcsc.c +++ b/src/bankd/driver_pcsc.c @@ -31,7 +31,6 @@ #include <talloc.h> #include <osmocom/core/linuxlist.h> -#include <osmocom/sim/sim.h> #include <wintypes.h> #include <winscard.h> diff --git a/src/bankd/main.c b/src/bankd/main.c index 23fa9d2..4bb91ca 100644 --- a/src/bankd/main.c +++ b/src/bankd/main.c @@ -29,7 +29,6 @@ #include <talloc.h> #include <osmocom/core/linuxlist.h> -#include <osmocom/sim/sim.h> #include <wintypes.h> #include <winscard.h> -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/17373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I015b1a49dbdd19d030acd929b5a935021b77cefa Gerrit-Change-Number: 17373 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200304/baee6561/attachment.htm>