<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-remsim/+/17373">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bankd: Avoid useless dependency to libosmosim<br><br>Change-Id: I015b1a49dbdd19d030acd929b5a935021b77cefa<br>dpkg-shlibdeps: warning: package could avoid a useless dependency if debian/osmo-remsim-bankd/usr/bin/osmo-remsim-bankd was not linked against libosmosim.so.0 (it uses none of the library's symbols)<br>---<br>M src/bankd/Makefile.am<br>M src/bankd/driver_pcsc.c<br>M src/bankd/main.c<br>3 files changed, 2 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/bankd/Makefile.am b/src/bankd/Makefile.am</span><br><span>index f2afa19..42c9bd3 100644</span><br><span>--- a/src/bankd/Makefile.am</span><br><span>+++ b/src/bankd/Makefile.am</span><br><span>@@ -1,6 +1,6 @@</span><br><span> AM_CFLAGS = -Wall -I$(top_srcdir)/include -I$(top_builddir)/include -I$(top_srcdir)/src \</span><br><span>        -I$(top_srcdir)/include/osmocom/rspro \</span><br><span style="color: hsl(0, 100%, 40%);">-         $(OSMOCORE_CFLAGS) $(OSMOGSM_CFLAGS) $(OSMOABIS_CFLAGS) $(OSMOSIM_CFLAGS) \</span><br><span style="color: hsl(120, 100%, 40%);">+           $(OSMOCORE_CFLAGS) $(OSMOGSM_CFLAGS) $(OSMOABIS_CFLAGS) \</span><br><span>            $(PCSC_CFLAGS)</span><br><span> </span><br><span> noinst_HEADERS = bankd.h internal.h</span><br><span>@@ -14,7 +14,7 @@</span><br><span> </span><br><span> osmo_remsim_bankd_SOURCES = ../slotmap.c ../rspro_client_fsm.c ../debug.c \</span><br><span>                           bankd_main.c bankd_pcsc.c</span><br><span style="color: hsl(0, 100%, 40%);">-osmo_remsim_bankd_LDADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOABIS_LIBS) $(OSMOSIM_LIBS) \</span><br><span style="color: hsl(120, 100%, 40%);">+osmo_remsim_bankd_LDADD = $(OSMOCORE_LIBS) $(OSMOGSM_LIBS) $(OSMOABIS_LIBS) \</span><br><span>                        $(PCSC_LIBS) $(CSV_LIBS) $(top_builddir)/src/libosmo-rspro.la</span><br><span> </span><br><span> # as suggested in http://lists.gnu.org/archive/html/automake/2009-03/msg00011.html</span><br><span>diff --git a/src/bankd/driver_pcsc.c b/src/bankd/driver_pcsc.c</span><br><span>index 5102512..03a7f32 100644</span><br><span>--- a/src/bankd/driver_pcsc.c</span><br><span>+++ b/src/bankd/driver_pcsc.c</span><br><span>@@ -31,7 +31,6 @@</span><br><span> </span><br><span> #include <talloc.h></span><br><span> #include <osmocom/core/linuxlist.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/sim/sim.h></span><br><span> </span><br><span> #include <wintypes.h></span><br><span> #include <winscard.h></span><br><span>diff --git a/src/bankd/main.c b/src/bankd/main.c</span><br><span>index 23fa9d2..4bb91ca 100644</span><br><span>--- a/src/bankd/main.c</span><br><span>+++ b/src/bankd/main.c</span><br><span>@@ -29,7 +29,6 @@</span><br><span> </span><br><span> #include <talloc.h></span><br><span> #include <osmocom/core/linuxlist.h></span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/sim/sim.h></span><br><span> </span><br><span> #include <wintypes.h></span><br><span> #include <winscard.h></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-remsim/+/17373">change 17373</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-remsim/+/17373"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-remsim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I015b1a49dbdd19d030acd929b5a935021b77cefa </div>
<div style="display:none"> Gerrit-Change-Number: 17373 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>