This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19029 ) Change subject: osmo-bts-trx/scheduler: refactor dummy burst scheduling ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/19029/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/19029/1/src/osmo-bts-trx/scheduler_trx.c@105 PS1, Line 105: c0_mask |= (1 << tn); > Why not simply moving all the code below inside this if condition and you don't need to work with th […] As I wrote in the commit message, you cannot immediately send a Dummy Burst here when freq. hopping is in use. If you do this here, then what if the next transceiver would want to send a Normal Bursts on ARFCN of C0? That's why we postpone dummy burst scheduling. https://gerrit.osmocom.org/c/osmo-bts/+/19029/1/src/osmo-bts-trx/scheduler_trx.c@124 PS1, Line 124: if (c0_mask & (1 << br.tn)) > don't you need to do the opposite? send when this holds true? '1'B means that a burst was [already] sent, otherwise we send a dummy burst. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8c3651c27d2991079e83b8abdb7e2c3f95b97a43 Gerrit-Change-Number: 19029 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 29 Jun 2020 09:58:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200629/db2f3eff/attachment.htm>