Change in osmo-bts[master]: osmo-bts-trx/scheduler: refactor dummy burst scheduling

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19029 )

Change subject: osmo-bts-trx/scheduler: refactor dummy burst scheduling
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/19029/1/src/common/scheduler.c 
File src/common/scheduler.c:

https://gerrit.osmocom.org/c/osmo-bts/+/19029/1/src/common/scheduler.c@56 
PS1, Line 56: const ubit_t _sched_dummy_burst[] = {
if it's GSM_BURST_LEN size, then please leave it there, it's convenient to quickly understand sizes of arrays in this case.


https://gerrit.osmocom.org/c/osmo-bts/+/19029/1/src/osmo-bts-trx/scheduler_trx.c 
File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/c/osmo-bts/+/19029/1/src/osmo-bts-trx/scheduler_trx.c@105 
PS1, Line 105: 				c0_mask |= (1 << tn);
Why not simply moving all the code below inside this if condition and you don't need to work with this c0_mask?


https://gerrit.osmocom.org/c/osmo-bts/+/19029/1/src/osmo-bts-trx/scheduler_trx.c@124 
PS1, Line 124: 		if (c0_mask & (1 << br.tn))
don't you need to do the opposite? send when this holds true?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19029
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I8c3651c27d2991079e83b8abdb7e2c3f95b97a43
Gerrit-Change-Number: 19029
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 29 Jun 2020 08:46:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200629/641b0d06/attachment.htm>