This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/19020 ) Change subject: sgsn_libgtp: Avoid ps-paging MS on GMM Suspended state ...................................................................... sgsn_libgtp: Avoid ps-paging MS on GMM Suspended state The MS notifies movement to GMM SUSPEND state because it is for instance handling a call and cannot use PDCH anymore. Once it releases the TCH it will ASAP move to either dedicated mode or trigger RAU, which means it will get out of SUSPEND state. So it doesn't make sense to try paging the MS when in that state. This change makes test TC_suspend_nopaging pass. Related: OS#4616 Change-Id: Ia245899eb9f16c7f839785def4ceb721a1c3a11b --- M src/sgsn/sgsn_libgtp.c 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/sgsn/sgsn_libgtp.c b/src/sgsn/sgsn_libgtp.c index 717df4a..581e74d 100644 --- a/src/sgsn/sgsn_libgtp.c +++ b/src/sgsn/sgsn_libgtp.c @@ -660,12 +660,10 @@ switch (mm->gmm_fsm->state) { case ST_GMM_REGISTERED_SUSPENDED: - /* initiate PS PAGING procedure */ - LOGMMCTXP(LOGL_INFO, mm, "Paging MS in GMM state %s\n", + LOGMMCTXP(LOGL_INFO, mm, "Dropping DL packet for MS in GMM state %s\n", osmo_fsm_inst_state_name(mm->gmm_fsm)); - gprs_gb_page_ps_ra(mm); - /* FIXME: queue the packet we received from GTP */ - break; + msgb_free(msg); + return -1; case ST_GMM_REGISTERED_NORMAL: OSMO_ASSERT(mm->gb.mm_state_fsm->state != ST_MM_IDLE); if (mm->gb.mm_state_fsm->state == ST_MM_STANDBY) { -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/19020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia245899eb9f16c7f839785def4ceb721a1c3a11b Gerrit-Change-Number: 19020 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200626/e72839f0/attachment.htm>