<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/19020">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sgsn_libgtp: Avoid ps-paging MS on GMM Suspended state<br><br>The MS notifies movement to GMM SUSPEND state because it is for instance<br>handling a call and cannot use PDCH anymore. Once it releases the TCH it<br>will ASAP move to either dedicated mode or trigger RAU, which means it<br>will get out of SUSPEND state. So it doesn't make sense to try paging<br>the MS when in that state.<br><br>This change makes test TC_suspend_nopaging pass.<br><br>Related: OS#4616<br>Change-Id: Ia245899eb9f16c7f839785def4ceb721a1c3a11b<br>---<br>M src/sgsn/sgsn_libgtp.c<br>1 file changed, 3 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sgsn/sgsn_libgtp.c b/src/sgsn/sgsn_libgtp.c</span><br><span>index 717df4a..581e74d 100644</span><br><span>--- a/src/sgsn/sgsn_libgtp.c</span><br><span>+++ b/src/sgsn/sgsn_libgtp.c</span><br><span>@@ -660,12 +660,10 @@</span><br><span> </span><br><span>  switch (mm->gmm_fsm->state) {</span><br><span>  case ST_GMM_REGISTERED_SUSPENDED:</span><br><span style="color: hsl(0, 100%, 40%);">-               /* initiate PS PAGING procedure */</span><br><span style="color: hsl(0, 100%, 40%);">-              LOGMMCTXP(LOGL_INFO, mm, "Paging MS in GMM state %s\n",</span><br><span style="color: hsl(120, 100%, 40%);">+             LOGMMCTXP(LOGL_INFO, mm, "Dropping DL packet for MS in GMM state %s\n",</span><br><span>                      osmo_fsm_inst_state_name(mm->gmm_fsm));</span><br><span style="color: hsl(0, 100%, 40%);">-            gprs_gb_page_ps_ra(mm);</span><br><span style="color: hsl(0, 100%, 40%);">-         /* FIXME: queue the packet we received from GTP */</span><br><span style="color: hsl(0, 100%, 40%);">-              break;</span><br><span style="color: hsl(120, 100%, 40%);">+                msgb_free(msg);</span><br><span style="color: hsl(120, 100%, 40%);">+               return -1;</span><br><span>   case ST_GMM_REGISTERED_NORMAL:</span><br><span>               OSMO_ASSERT(mm->gb.mm_state_fsm->state != ST_MM_IDLE);</span><br><span>                 if (mm->gb.mm_state_fsm->state == ST_MM_STANDBY) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/19020">change 19020</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/19020"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia245899eb9f16c7f839785def4ceb721a1c3a11b </div>
<div style="display:none"> Gerrit-Change-Number: 19020 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>