Change in osmo-msc[master]: refactor: move RESET Osmux TLV parsing to ran_msg_a.c

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Fri Jun 26 16:11:12 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19024 )

Change subject: refactor: move RESET Osmux TLV parsing to ran_msg_a.c
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-msc/+/19024/2/src/libmsc/ran_msg_a.c 
File src/libmsc/ran_msg_a.c:

https://gerrit.osmocom.org/c/osmo-msc/+/19024/2/src/libmsc/ran_msg_a.c@1314 
PS2, Line 1314: 	l2->l3h = msgb_l2(l2) + sizeof(struct bssmap_header);
> I find it a bit strange that a "getter" function simply checking the type of message is actually upd […]
Ack



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/19024
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I1ad4a3f9356216dd4bf8c48fba29fd23438810a7
Gerrit-Change-Number: 19024
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 26 Jun 2020 16:11:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200626/02af48ca/attachment.htm>


More information about the gerrit-log mailing list