This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19024 ) Change subject: refactor: move RESET Osmux TLV parsing to ran_msg_a.c ...................................................................... Patch Set 2: Code-Review+1 (3 comments) TBH I don't see a problem with also checking for osmux support on RANAP, even if no HNGBW or whatever doesn't support it yet, it may in the future. That being said, if you think it's more convenient or there's any benefit in doing it this way for whatever reason then fine with me. https://gerrit.osmocom.org/c/osmo-msc/+/19024/2/src/libmsc/ran_msg_a.c File src/libmsc/ran_msg_a.c: https://gerrit.osmocom.org/c/osmo-msc/+/19024/2/src/libmsc/ran_msg_a.c@1283 PS2, Line 1283: if (supports_osmux == NULL) simply check supports_osmux in bssmap_is_reset_msg()? What abnout simply returning a bool? https://gerrit.osmocom.org/c/osmo-msc/+/19024/2/src/libmsc/ran_msg_a.c@1314 PS2, Line 1314: l2->l3h = msgb_l2(l2) + sizeof(struct bssmap_header); I find it a bit strange that a "getter" function simply checking the type of message is actually updating the msgb. https://gerrit.osmocom.org/c/osmo-msc/+/19024/2/src/libmsc/ran_msg_iu.c File src/libmsc/ran_msg_iu.c: https://gerrit.osmocom.org/c/osmo-msc/+/19024/2/src/libmsc/ran_msg_iu.c@447 PS2, Line 447: if (supports_osmux != NULL) You are using "if (supports_osmux)" on the other, you could use it too here. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/19024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1ad4a3f9356216dd4bf8c48fba29fd23438810a7 Gerrit-Change-Number: 19024 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 26 Jun 2020 13:52:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200626/1e40c4a5/attachment.htm>