Change in osmo-bts[master]: bts-trx: Mark 'osmotrx power' VTY cmd as deprecated

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18968 )

Change subject: bts-trx: Mark 'osmotrx power' VTY cmd as deprecated
......................................................................

bts-trx: Mark 'osmotrx power' VTY cmd as deprecated

There's a standarized way through OML's Administrate State to control
the status of TRX, so let's use and maintain that one rather than this
ad-hoc hack.

Related: SYS#4920
Change-Id: Ia7f190063c35e0ed8e2e734047b3aff608cd3ce3
---
M src/osmo-bts-trx/trx_vty.c
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c
index b3214ee..2e52958 100644
--- a/src/osmo-bts-trx/trx_vty.c
+++ b/src/osmo-bts-trx/trx_vty.c
@@ -296,7 +296,7 @@
 	return CMD_SUCCESS;
 }
 
-DEFUN(cfg_phyinst_power_on, cfg_phyinst_power_on_cmd,
+DEFUN_DEPRECATED(cfg_phyinst_power_on, cfg_phyinst_power_on_cmd,
 	"osmotrx power (on|off)",
 	OSMOTRX_STR
 	"Change TRX state\n"
@@ -305,6 +305,10 @@
 	struct phy_instance *pinst = vty->index;
 	struct trx_l1h *l1h = pinst->u.osmotrx.hdl;
 
+	vty_out (vty, "'osmotrx power' is deprecated, use OML's standard "
+		      "Administrative State instead to control each TRX "
+		      "('rf_locked' VTY cmd in osmo-bsc)%s", VTY_NEWLINE);
+
 	if (strcmp(argv[0], "on"))
 		vty_out(vty, "OFF: %d%s", trx_if_cmd_poweroff(l1h, NULL), VTY_NEWLINE);
 	else {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18968
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia7f190063c35e0ed8e2e734047b3aff608cd3ce3
Gerrit-Change-Number: 18968
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200623/5d396263/attachment.htm>