Change in osmo-msc[master]: make vty-transcrip-test: use $VTY_TEST var like osmo-bsc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Mon Jun 22 16:47:02 UTC 2020


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/18969 )


Change subject: make vty-transcrip-test: use $VTY_TEST var like osmo-bsc
......................................................................

make vty-transcrip-test: use $VTY_TEST var like osmo-bsc

Adopt the same way to run manual vty transcript tests as in
osmo-bsc/test/Makefile.am.

There are different ways to select a specific test to run in osmo-bsc and here
in osmo-msc. The osmo-bsc way is more convenient when building outside the src
tree, because it does not need the full absolute path of the test file.

Change-Id: If1e2abfa321a5e9fb60358d1f0e4e448b33184af
---
M tests/Makefile.am
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/69/18969/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 5af80a4..c765158 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -71,6 +71,9 @@
 	$(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v
 	rm -f $(top_builddir)/sms.db
 
+# Run a specific transcript test with: 'make vty-transcript-test VTY_TEST=osmo-msc.vty'
+VTY_TEST ?= *.vty
+
 # To update the VTY script from current application behavior,
 # pass -u to vty_script_runner.py by doing:
 #   make vty-transcript-test U=-u
@@ -78,7 +81,7 @@
 	osmo_verify_transcript_vty.py -v \
 		-n OsmoMSC -p 4254 \
 		-r "$(top_builddir)/src/osmo-msc/osmo-msc -c $(top_srcdir)/doc/examples/osmo-msc/osmo-msc.cfg" \
-		$(U) $${T:-$(srcdir)/*.vty}
+		$(U) $(srcdir)/$(VTY_TEST)
 	rm -f $(builddir)/sms.db
 
 # don't run multiple tests concurrently so that the ports don't conflict

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/18969
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: If1e2abfa321a5e9fb60358d1f0e4e448b33184af
Gerrit-Change-Number: 18969
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200622/10a8c6d8/attachment.htm>


More information about the gerrit-log mailing list