Change in osmo-bts[master]: bts_model: Convert bts_model_trx_close() to return asynchronously

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18953 )

Change subject: bts_model: Convert bts_model_trx_close() to return asynchronously
......................................................................


Patch Set 2:

(6 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/include/osmo-bts/bts_model.h 
File include/osmo-bts/bts_model.h:

https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/include/osmo-bts/bts_model.h@34 
PS2, Line 34: /* Implementation should call bts_model_trx_close_cb when done */
> (possibly better place the comment in the . […]
There's no global C file, precisely because each backend should implement these functions, and this is the reference header people look at when adding a new backend.


https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/include/osmo-bts/bts_model.h@71 
PS2, Line 71: void bts_model_trx_close_cb(struct gsm_bts_trx *trx, int rc);
> (maybe "closed_cb" with d)
I'm keeping the function name initiating it and adding_cb to it.


https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/src/osmo-bts-omldummy/bts_model.c 
File src/osmo-bts-omldummy/bts_model.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/src/osmo-bts-omldummy/bts_model.c@53 
PS2, Line 53: void bts_model_trx_close(struct gsm_bts_trx *trx)
> separate fix?
Not really, I'm moving the return code to be returned in the callback function.


https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/src/osmo-bts-omldummy/bts_model.c@55 
PS2, Line 55: 	LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__);
> i guess it's implemented now? :)
Not really, I'm simply returning the callback method as requested by the bts_model, but specific stuff for this backend is not really yet implemented. I'm simply keeping old behavior here.


https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/src/osmo-bts-trx/l1_if.c 
File src/osmo-bts-trx/l1_if.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/src/osmo-bts-trx/l1_if.c@444 
PS2, Line 444: 	} else if (!pinst->phy_link->u.osmotrx.poweronoff_sent) {
> this is immediately responding with close_cb() in case it was never powered on? (explain in a commen […]
Yes. I think it's clear since it's already explained in the definition of the function in bts_model.h


https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/src/osmo-bts-virtual/bts_model.c 
File src/osmo-bts-virtual/bts_model.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/src/osmo-bts-virtual/bts_model.c@55 
PS2, Line 55: 	LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__);
> (implemented now)
No really, already explained.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18953
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7d76b600fc06e1114b35bf0c2d08eff5bbd1b69a
Gerrit-Change-Number: 18953
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 23 Jun 2020 10:17:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200623/78f20f32/attachment.htm>