This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18953 ) Change subject: bts_model: Convert bts_model_trx_close() to return asynchronously ...................................................................... Patch Set 2: Code-Review+1 (8 comments) https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/include/osmo-bts/bts_model.h File include/osmo-bts/bts_model.h: https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/include/osmo-bts/bts_model.h@34 PS2, Line 34: /* Implementation should call bts_model_trx_close_cb when done */ (possibly better place the comment in the .c file?) https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/include/osmo-bts/bts_model.h@67 PS2, Line 67: /* BTS model specific implementations are expected to call this functions as a ("this function" vs "these functions") https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/include/osmo-bts/bts_model.h@71 PS2, Line 71: void bts_model_trx_close_cb(struct gsm_bts_trx *trx, int rc); (maybe "closed_cb" with d) https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/src/osmo-bts-omldummy/bts_model.c File src/osmo-bts-omldummy/bts_model.c: https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/src/osmo-bts-omldummy/bts_model.c@53 PS2, Line 53: void bts_model_trx_close(struct gsm_bts_trx *trx) separate fix? https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/src/osmo-bts-omldummy/bts_model.c@55 PS2, Line 55: LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__); i guess it's implemented now? :) https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/src/osmo-bts-trx/l1_if.c File src/osmo-bts-trx/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/src/osmo-bts-trx/l1_if.c@217 PS2, Line 217: if (rc == 0 && plink->state != PHY_LINK_CONNECTED) { (the cosmetic plink change confused me reading the patch) https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/src/osmo-bts-trx/l1_if.c@444 PS2, Line 444: } else if (!pinst->phy_link->u.osmotrx.poweronoff_sent) { this is immediately responding with close_cb() in case it was never powered on? (explain in a comment?) https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/src/osmo-bts-virtual/bts_model.c File src/osmo-bts-virtual/bts_model.c: https://gerrit.osmocom.org/c/osmo-bts/+/18953/2/src/osmo-bts-virtual/bts_model.c@55 PS2, Line 55: LOGP(DL1C, LOGL_NOTICE, "Unimplemented %s\n", __func__); (implemented now) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I7d76b600fc06e1114b35bf0c2d08eff5bbd1b69a Gerrit-Change-Number: 18953 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jun 2020 18:16:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200622/66f2bb85/attachment.htm>