This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18904 ) Change subject: Implement tx power ramp down during BTS shutdown ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/18904/3/src/common/bts_shutdown_fsm.c File src/common/bts_shutdown_fsm.c: https://gerrit.osmocom.org/c/osmo-bts/+/18904/3/src/common/bts_shutdown_fsm.c@78 PS3, Line 78: if (trx->power_params.p_total_cur_mdBm > 0) > so the mdBm <= 0 corresponds to the to_mdB(-10) above? […] Yes, I opted to make it more robust by simply checking it reached at least 0. In any case theoretically the callback is not called until the target is reached, but I thought it was more robust to check for 0 here in case some TRX backend for whatever reason plays wrong with negative values and we end up with only 0 being set. I can change it if you want, not really important imho. https://gerrit.osmocom.org/c/osmo-bts/+/18904/3/src/common/gsm_data.c File src/common/gsm_data.c: https://gerrit.osmocom.org/c/osmo-bts/+/18904/3/src/common/gsm_data.c@44 PS3, Line 44: * shutdown start based on params below, and highest trx value taken: > (if it is a sanity timeout then a fixed number should be fine IMO) well the problem here is that the timeout can be quite large if specific the power-ramp params are set, so ideally it'd be better to make the sanity timeout adaptative. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18904 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I70e34dda8974ebd94aea33bd9fb1d99f9063cc55 Gerrit-Change-Number: 18904 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: neels <nhofmeyr at sysmocom.de> Gerrit-Comment-Date: Mon, 22 Jun 2020 18:15:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200622/5b668d63/attachment.htm>