Change in osmo-bts[master]: Implement tx power ramp down during BTS shutdown

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Mon Jun 22 17:56:53 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18904 )

Change subject: Implement tx power ramp down during BTS shutdown
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/18904/3/src/common/bts_shutdown_fsm.c 
File src/common/bts_shutdown_fsm.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18904/3/src/common/bts_shutdown_fsm.c@78 
PS3, Line 78: 			if (trx->power_params.p_total_cur_mdBm > 0)
so the mdBm <= 0 corresponds to the to_mdB(-10) above?
Asking because that's the only thing making sure we've actually received the ramp_down_compl_cb for each trx, and the relation is not obvious (enough) to me.


https://gerrit.osmocom.org/c/osmo-bts/+/18904/3/src/common/gsm_data.c 
File src/common/gsm_data.c:

https://gerrit.osmocom.org/c/osmo-bts/+/18904/3/src/common/gsm_data.c@44 
PS3, Line 44: 	 * shutdown start based on params below, and highest trx value taken:
(if it is a sanity timeout then a fixed number should be fine IMO)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18904
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I70e34dda8974ebd94aea33bd9fb1d99f9063cc55
Gerrit-Change-Number: 18904
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Mon, 22 Jun 2020 17:56:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200622/fb527b68/attachment.htm>


More information about the gerrit-log mailing list