Change in osmo-bts[master]: scheduler: Add rate_ctr informing about Dl block not found

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18863 )

Change subject: scheduler: Add rate_ctr informing about Dl block not found
......................................................................

scheduler: Add rate_ctr informing about Dl block not found

Together with previous counter L1SCHED_TS_CTR_DL_LATE, it allows
understanding which dl blocks are really lost (never queued) and which
were simply queued too late.

Change-Id: I456d0cfbef1e03b147ce7d968a3ec42dd728fe74
---
M src/common/scheduler.c
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  neels: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/common/scheduler.c b/src/common/scheduler.c
index b539733..01edc69 100644
--- a/src/common/scheduler.c
+++ b/src/common/scheduler.c
@@ -566,10 +566,12 @@
 
 enum {
 	L1SCHED_TS_CTR_DL_LATE,
+	L1SCHED_TS_CTR_DL_NOT_FOUND,
 };
 
 static const struct rate_ctr_desc l1sched_ts_ctr_desc[] = {
 	[L1SCHED_TS_CTR_DL_LATE] =	{"l1sched_ts:dl_late", "Downlink frames arrived too late to submit to lower layers"},
+	[L1SCHED_TS_CTR_DL_NOT_FOUND] =	{"l1sched_ts:dl_not_found", "Downlink frames not found while scheduling"},
 };
 static const struct rate_ctr_group_desc l1sched_ts_ctrg_desc = {
 	"l1sched_ts",
@@ -698,7 +700,7 @@
 			continue;
 		}
 		if (prim_fn > 0) /* l1sap_fn > fn */
-			return NULL;
+			break;
 
 		/* l1sap_fn == fn */
 		if ((chan_nr ^ (trx_chan_desc[chan].chan_nr | tn))
@@ -714,6 +716,8 @@
 		return msg;
 	}
 
+	/* Queue was traversed with no candidate, no prim is available for current FN: */
+	rate_ctr_inc2(l1ts->ctrs, L1SCHED_TS_CTR_DL_NOT_FOUND);
 	return NULL;
 
 free_msg:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18863
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I456d0cfbef1e03b147ce7d968a3ec42dd728fe74
Gerrit-Change-Number: 18863
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200618/66f372c6/attachment.htm>