<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/18863">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, approved
neels: Looks good to me, but someone else must approve
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">scheduler: Add rate_ctr informing about Dl block not found<br><br>Together with previous counter L1SCHED_TS_CTR_DL_LATE, it allows<br>understanding which dl blocks are really lost (never queued) and which<br>were simply queued too late.<br><br>Change-Id: I456d0cfbef1e03b147ce7d968a3ec42dd728fe74<br>---<br>M src/common/scheduler.c<br>1 file changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/scheduler.c b/src/common/scheduler.c</span><br><span>index b539733..01edc69 100644</span><br><span>--- a/src/common/scheduler.c</span><br><span>+++ b/src/common/scheduler.c</span><br><span>@@ -566,10 +566,12 @@</span><br><span> </span><br><span> enum {</span><br><span> L1SCHED_TS_CTR_DL_LATE,</span><br><span style="color: hsl(120, 100%, 40%);">+ L1SCHED_TS_CTR_DL_NOT_FOUND,</span><br><span> };</span><br><span> </span><br><span> static const struct rate_ctr_desc l1sched_ts_ctr_desc[] = {</span><br><span> [L1SCHED_TS_CTR_DL_LATE] = {"l1sched_ts:dl_late", "Downlink frames arrived too late to submit to lower layers"},</span><br><span style="color: hsl(120, 100%, 40%);">+ [L1SCHED_TS_CTR_DL_NOT_FOUND] = {"l1sched_ts:dl_not_found", "Downlink frames not found while scheduling"},</span><br><span> };</span><br><span> static const struct rate_ctr_group_desc l1sched_ts_ctrg_desc = {</span><br><span> "l1sched_ts",</span><br><span>@@ -698,7 +700,7 @@</span><br><span> continue;</span><br><span> }</span><br><span> if (prim_fn > 0) /* l1sap_fn > fn */</span><br><span style="color: hsl(0, 100%, 40%);">- return NULL;</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span> </span><br><span> /* l1sap_fn == fn */</span><br><span> if ((chan_nr ^ (trx_chan_desc[chan].chan_nr | tn))</span><br><span>@@ -714,6 +716,8 @@</span><br><span> return msg;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Queue was traversed with no candidate, no prim is available for current FN: */</span><br><span style="color: hsl(120, 100%, 40%);">+ rate_ctr_inc2(l1ts->ctrs, L1SCHED_TS_CTR_DL_NOT_FOUND);</span><br><span> return NULL;</span><br><span> </span><br><span> free_msg:</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/18863">change 18863</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/18863"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I456d0cfbef1e03b147ce7d968a3ec42dd728fe74 </div>
<div style="display:none"> Gerrit-Change-Number: 18863 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>