This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18821 ) Change subject: osmo-bts-trx: introduce and use struct trx_dl_burst_req ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/18821/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/18821/1/src/osmo-bts-trx/scheduler_trx.c@89 PS1, Line 89: /* TODO: Tx attenuation is always 0? */ > Right. Do you know if osmo-trx supports per-burst power attenuation? […] osmo-trx does use the value, see Transceiver::addRadioVector() https://git.osmocom.org/osmo-trx/tree/Transceiver52M/Transceiver.cpp#n373 (the variable is wrongly named RSSI there): """ addRadioVector(chan, newBurst, dl->tx_att, currTime); // which uses it like this: (dl->tx_att is RSSI) scaleVector(*burst, txFullScale * pow(10, -RSSI / 10)); """ According to Harald the attenuation value is to be applied on top of already global one, so iiuc it's doing the correct thing here (further attenuating it if the value is !=0). -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If3014e69746559963569b77561dbf7b163c68ffa Gerrit-Change-Number: 18821 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 15 Jun 2020 10:20:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200615/d517e115/attachment.htm>