This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18821 ) Change subject: osmo-bts-trx: introduce and use struct trx_dl_burst_req ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/18821/1/src/common/scheduler.c File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/18821/1/src/common/scheduler.c@1210 PS1, Line 1210: br->burst_len = ARRAY_SIZE(dummy_burst); > Be careful here, iirc when I fixed this for EGPRS a few days ago, func() above (or some code before […] Yep, I remember your fix. The general rule is that a logical channel handler, i.e. func(), sets br->burst_len *iff* br->burst contains a valid burst. By default, both br->burst and br->burst_len are zero-initialized, so in the worst case we will Tx a sequence of zeros. Given that I refactored all lchan handlers, I don't think it's possible. https://gerrit.osmocom.org/c/osmo-bts/+/18821/1/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/18821/1/src/osmo-bts-trx/scheduler_trx.c@89 PS1, Line 89: /* TODO: Tx attenuation is always 0? */ > we should get it from lchan->bs_power I think. Right. Do you know if osmo-trx supports per-burst power attenuation? "The Power Level field (octet 2) indicates the number of 2 dB steps by which the power shall be reduced from its nominal value, Pn, set by the network operator to adjust the coverage." -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18821 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If3014e69746559963569b77561dbf7b163c68ffa Gerrit-Change-Number: 18821 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 15 Jun 2020 09:54:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200615/ed11d248/attachment.htm>