Change in libosmocore[master]: lapd/lapdm: print user-defined string name instead of (dl=%p)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Sun Jun 7 21:05:03 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/18002 )

Change subject: lapd/lapdm: print user-defined string name instead of (dl=%p)
......................................................................


Patch Set 8:

(3 comments)

https://gerrit.osmocom.org/c/libosmocore/+/18002/8/include/osmocom/gsm/lapd_core.h 
File include/osmocom/gsm/lapd_core.h:

https://gerrit.osmocom.org/c/libosmocore/+/18002/8/include/osmocom/gsm/lapd_core.h@168 
PS8, Line 168: 	OSMO_DEPRECATED("Use lapd_dl_init2() instaed");
typo: instead


https://gerrit.osmocom.org/c/libosmocore/+/18002/8/include/osmocom/gsm/lapdm.h 
File include/osmocom/gsm/lapdm.h:

https://gerrit.osmocom.org/c/libosmocore/+/18002/8/include/osmocom/gsm/lapdm.h@89 
PS8, Line 89: 	OSMO_DEPRECATED("Use lapdm_entity_init3() instead");
As a general comment, you don't need to deprecate stuff if it was added after last release (not saying it's the case here). You are free to change APIs not yet released.


https://gerrit.osmocom.org/c/libosmocore/+/18002/8/src/gsm/lapd_core.c 
File src/gsm/lapd_core.c:

https://gerrit.osmocom.org/c/libosmocore/+/18002/8/src/gsm/lapd_core.c@307 
PS8, Line 307: 		dl->name = talloc_strdup(tall_lapd_ctx, name);
see my previous comment, don't you need osmo_talloc_replace() (or however it's called) here?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/18002
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie6742843fff809edffcac24c4dce4edf66bc71be
Gerrit-Change-Number: 18002
Gerrit-PatchSet: 8
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 07 Jun 2020 21:05:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200607/8eb6b98d/attachment.htm>


More information about the gerrit-log mailing list