<p><a href="https://gerrit.osmocom.org/c/libosmocore/+/18002">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/18002/8/include/osmocom/gsm/lapd_core.h">File include/osmocom/gsm/lapd_core.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/18002/8/include/osmocom/gsm/lapd_core.h@168">Patch Set #8, Line 168:</a> <code style="font-family:monospace,monospace">     OSMO_DEPRECATED("Use lapd_dl_init2() instaed");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">typo: instead</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/18002/8/include/osmocom/gsm/lapdm.h">File include/osmocom/gsm/lapdm.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/18002/8/include/osmocom/gsm/lapdm.h@89">Patch Set #8, Line 89:</a> <code style="font-family:monospace,monospace">     OSMO_DEPRECATED("Use lapdm_entity_init3() instead");</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">As a general comment, you don't need to deprecate stuff if it was added after last release (not saying it's the case here). You are free to change APIs not yet released.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/18002/8/src/gsm/lapd_core.c">File src/gsm/lapd_core.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmocore/+/18002/8/src/gsm/lapd_core.c@307">Patch Set #8, Line 307:</a> <code style="font-family:monospace,monospace">          dl->name = talloc_strdup(tall_lapd_ctx, name);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">see my previous comment, don't you need osmo_talloc_replace() (or however it's called) here?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/18002">change 18002</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/18002"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie6742843fff809edffcac24c4dce4edf66bc71be </div>
<div style="display:none"> Gerrit-Change-Number: 18002 </div>
<div style="display:none"> Gerrit-PatchSet: 8 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 07 Jun 2020 21:05:03 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>