Change in pysim[master]: Implement Generic SIM Access interface as per 3GPP TS 27.007

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

guilly@gmail.com gerrit-no-reply at lists.osmocom.org
Tue Jun 2 13:52:06 UTC 2020


guilly at gmail.com has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 )

Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007
......................................................................


Patch Set 5:

> Patch Set 5:
> 
> (1 comment)

yes, I was running it with python 2, I thought it was not upgraded to 3. The header of pySim-read still uses python2 :-)

I was getting a unicode object, and that was exposing the problem.

When running send_pdu, it was requesting extra data with this part, not sure why pdu_gr was type unicode

		if (sw is not None) and ((sw[0:2] == '9f') or (sw[0:2] == '61')):
			pdu_gr = pdu[0:2] + 'c00000' + sw[2:4]
			data, sw = self.send_apdu_raw(pdu_gr)


Still, if cmd is not a str, you will not initialise bcmd, so probably need to add something in the else?


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/18159
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I20bc00315e2c7c298f46283852865c1416047bc6
Gerrit-Change-Number: 18159
Gerrit-PatchSet: 5
Gerrit-Owner: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: guilly at gmail.com <guilly at gmail.com>
Gerrit-Comment-Date: Tue, 02 Jun 2020 13:52:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200602/a2cf799f/attachment.htm>


More information about the gerrit-log mailing list