This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Vadim Yanitskiy gerrit-no-reply at lists.osmocom.orgVadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/18159 ) Change subject: Implement Generic SIM Access interface as per 3GPP TS 27.007 ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/pysim/+/18159/5/pySim/transport/modem_atcmd.py File pySim/transport/modem_atcmd.py: https://gerrit.osmocom.org/c/pysim/+/18159/5/pySim/transport/modem_atcmd.py@50 PS5, Line 50: if type(cmd) is str: > there is a problem here if cmd is not a string, as it's not initiliased. I am not getting what you mean here, sorry. If it's not a string, it should be bytes. > I thought the purpouse of this was to turn the string into bytes? Yes, as written in the comment above. Either it's a string, so we convert it to bytes, or it's already bytes, so we use it as-is. I guess you're still using Python 2? AFAIR, unlike Python 3, type(b'\xff') in Python 2 would be 'str', not 'bytes' as expected. If so, I am not going to fix / work around this. > bcmd = cmd.encode() This does not work with Python 3 :/ AttributeError: 'bytes' object has no attribute 'encode' -- To view, visit https://gerrit.osmocom.org/c/pysim/+/18159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I20bc00315e2c7c298f46283852865c1416047bc6 Gerrit-Change-Number: 18159 Gerrit-PatchSet: 5 Gerrit-Owner: Vadim Yanitskiy <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: guilly at gmail.com <guilly at gmail.com> Gerrit-Comment-Date: Tue, 02 Jun 2020 13:22:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: guilly at gmail.com <guilly at gmail.com> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200602/48a1d1b8/attachment.htm>