Change in osmo-bsc[master]: fix CBSP server: actually open the srv_link

[neels]

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/19441 )

Change subject: fix CBSP server: actually open the srv_link
......................................................................

fix CBSP server: actually open the srv_link

Change-Id: Ic688573e179381f7798055b647200e508f1bc37f
---
M src/osmo-bsc/cbsp_link.c
1 file changed, 10 insertions(+), 3 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/cbsp_link.c b/src/osmo-bsc/cbsp_link.c
index 91217ad..d93bd1a 100644
--- a/src/osmo-bsc/cbsp_link.c
+++ b/src/osmo-bsc/cbsp_link.c
@@ -239,13 +239,20 @@
 	if (cbc->config.listen_port != -1) {
 		LOGP(DCBS, LOGL_NOTICE, "Starting CBSP Server (bound to %s:%u)\n",
 			cbc->config.listen_hostname, cbc->config.listen_port);
-		if (!cbc->server.srv) {
+		if (!cbc->server.link) {
+			LOGP(DCBS, LOGL_NOTICE, "Creating CBSP Server\n");
 			cbc->server.link = osmo_stream_srv_link_create(cbc);
 			osmo_stream_srv_link_set_data(cbc->server.link, cbc);
 			osmo_stream_srv_link_set_accept_cb(cbc->server.link, cbsp_srv_link_accept_cb);
+
+			osmo_stream_srv_link_set_addr(cbc->server.link, cbc->config.listen_hostname);
+			osmo_stream_srv_link_set_port(cbc->server.link, cbc->config.listen_port);
+
+			if (osmo_stream_srv_link_open(cbc->server.link) < 0) {
+				LOGP(DCBS, LOGL_ERROR, "Cannot open CBSP Server link on %s:%u\n",
+				     cbc->config.listen_hostname, cbc->config.listen_port);
+			}
 		}
-		osmo_stream_srv_link_set_addr(cbc->server.link, cbc->config.listen_hostname);
-		osmo_stream_srv_link_set_port(cbc->server.link, cbc->config.listen_port);
 	}
 	return 0;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/19441
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic688573e179381f7798055b647200e508f1bc37f
Gerrit-Change-Number: 19441
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200730/905fb610/attachment.htm>