<p>neels <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19441">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">fix CBSP server: actually open the srv_link<br><br>Change-Id: Ic688573e179381f7798055b647200e508f1bc37f<br>---<br>M src/osmo-bsc/cbsp_link.c<br>1 file changed, 10 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-bsc/cbsp_link.c b/src/osmo-bsc/cbsp_link.c</span><br><span>index 91217ad..d93bd1a 100644</span><br><span>--- a/src/osmo-bsc/cbsp_link.c</span><br><span>+++ b/src/osmo-bsc/cbsp_link.c</span><br><span>@@ -239,13 +239,20 @@</span><br><span>         if (cbc->config.listen_port != -1) {</span><br><span>              LOGP(DCBS, LOGL_NOTICE, "Starting CBSP Server (bound to %s:%u)\n",</span><br><span>                         cbc->config.listen_hostname, cbc->config.listen_port);</span><br><span style="color: hsl(0, 100%, 40%);">-            if (!cbc->server.srv) {</span><br><span style="color: hsl(120, 100%, 40%);">+            if (!cbc->server.link) {</span><br><span style="color: hsl(120, 100%, 40%);">+                   LOGP(DCBS, LOGL_NOTICE, "Creating CBSP Server\n");</span><br><span>                         cbc->server.link = osmo_stream_srv_link_create(cbc);</span><br><span>                      osmo_stream_srv_link_set_data(cbc->server.link, cbc);</span><br><span>                     osmo_stream_srv_link_set_accept_cb(cbc->server.link, cbsp_srv_link_accept_cb);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                   osmo_stream_srv_link_set_addr(cbc->server.link, cbc->config.listen_hostname);</span><br><span style="color: hsl(120, 100%, 40%);">+                   osmo_stream_srv_link_set_port(cbc->server.link, cbc->config.listen_port);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+                     if (osmo_stream_srv_link_open(cbc->server.link) < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                          LOGP(DCBS, LOGL_ERROR, "Cannot open CBSP Server link on %s:%u\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                                cbc->config.listen_hostname, cbc->config.listen_port);</span><br><span style="color: hsl(120, 100%, 40%);">+                     }</span><br><span>            }</span><br><span style="color: hsl(0, 100%, 40%);">-               osmo_stream_srv_link_set_addr(cbc->server.link, cbc->config.listen_hostname);</span><br><span style="color: hsl(0, 100%, 40%);">-             osmo_stream_srv_link_set_port(cbc->server.link, cbc->config.listen_port);</span><br><span>      }</span><br><span>    return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/19441">change 19441</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/19441"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic688573e179381f7798055b647200e508f1bc37f </div>
<div style="display:none"> Gerrit-Change-Number: 19441 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>