Change in osmo-ttcn3-hacks[master]: library/RLCMAC_CSN1_Types: fix byte/bit order in GprsMobileAllication

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19342 )

Change subject: library/RLCMAC_CSN1_Types: fix byte/bit order in GprsMobileAllication
......................................................................

library/RLCMAC_CSN1_Types: fix byte/bit order in GprsMobileAllication

According to 3GPP TS 44.060, table 12.10a.2, given that the number
of bit positions in MA_BITMAP equals NF, the first bit position
in MA_BITMAP corresponds to ARFCN_INDEX = NF-1, the last position
corresponds to ARFCN_INDEX = 0.

To put differently, the following bitstring in TITAN:

   0                 N    // N = NF - 1
  -------------------->
   0001 1011 1110 0100    // '0001101111100100'B

needs to be be encoded as follows 'on the wire':

   N                 0    // N = NF - 1
  <--------------------
   0010 0111 1101 1000    // '0010011111011000'B

so it basically gets inversed.  Let's add both BYTEORDER and
BITORDER attributes to achieve that.

Change-Id: I8f2c8c7b234605523a4fd518210b45ea3c088ff6
Related: SYS#4868, OS#4547
---
M library/RLCMAC_CSN1_Types.ttcn
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/library/RLCMAC_CSN1_Types.ttcn b/library/RLCMAC_CSN1_Types.ttcn
index 4ebdd75..6bdca40 100644
--- a/library/RLCMAC_CSN1_Types.ttcn
+++ b/library/RLCMAC_CSN1_Types.ttcn
@@ -814,7 +814,8 @@
 		variant (ma_length) "PRESENCE(ma_present = '0'B)"
 		variant (ma_bitmap) "PRESENCE(ma_present = '0'B)"
 		variant (ma_length) "LENGTHTO(ma_bitmap)+1"
-	}
+		variant (ma_bitmap) "BYTEORDER(first), BITORDER(msb)"
+	};
 
 	/* 12.11 Packet Request Reference */
 	type record PacketRequestReference {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19342
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8f2c8c7b234605523a4fd518210b45ea3c088ff6
Gerrit-Change-Number: 19342
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200723/54e836dc/attachment.htm>