<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19342">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">library/RLCMAC_CSN1_Types: fix byte/bit order in GprsMobileAllication<br><br>According to 3GPP TS 44.060, table 12.10a.2, given that the number<br>of bit positions in MA_BITMAP equals NF, the first bit position<br>in MA_BITMAP corresponds to ARFCN_INDEX = NF-1, the last position<br>corresponds to ARFCN_INDEX = 0.<br><br>To put differently, the following bitstring in TITAN:<br><br>   0                 N    // N = NF - 1<br>  --------------------><br>   0001 1011 1110 0100    // '0001101111100100'B<br><br>needs to be be encoded as follows 'on the wire':<br><br>   N                 0    // N = NF - 1<br>  <--------------------<br>   0010 0111 1101 1000    // '0010011111011000'B<br><br>so it basically gets inversed.  Let's add both BYTEORDER and<br>BITORDER attributes to achieve that.<br><br>Change-Id: I8f2c8c7b234605523a4fd518210b45ea3c088ff6<br>Related: SYS#4868, OS#4547<br>---<br>M library/RLCMAC_CSN1_Types.ttcn<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/library/RLCMAC_CSN1_Types.ttcn b/library/RLCMAC_CSN1_Types.ttcn</span><br><span>index 4ebdd75..6bdca40 100644</span><br><span>--- a/library/RLCMAC_CSN1_Types.ttcn</span><br><span>+++ b/library/RLCMAC_CSN1_Types.ttcn</span><br><span>@@ -814,7 +814,8 @@</span><br><span>             variant (ma_length) "PRESENCE(ma_present = '0'B)"</span><br><span>          variant (ma_bitmap) "PRESENCE(ma_present = '0'B)"</span><br><span>          variant (ma_length) "LENGTHTO(ma_bitmap)+1"</span><br><span style="color: hsl(0, 100%, 40%);">-   }</span><br><span style="color: hsl(120, 100%, 40%);">+             variant (ma_bitmap) "BYTEORDER(first), BITORDER(msb)"</span><br><span style="color: hsl(120, 100%, 40%);">+       };</span><br><span> </span><br><span>       /* 12.11 Packet Request Reference */</span><br><span>         type record PacketRequestReference {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19342">change 19342</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19342"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8f2c8c7b234605523a4fd518210b45ea3c088ff6 </div>
<div style="display:none"> Gerrit-Change-Number: 19342 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>