Change in libosmo-abis[master]: e1_input: Use osmo_use_count in e1inp_line

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Jul 15 14:53:52 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19256 )

Change subject: e1_input: Use osmo_use_count in e1inp_line
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/libosmo-abis/+/19256/3/include/osmocom/abis/e1_input.h 
File include/osmocom/abis/e1_input.h:

https://gerrit.osmocom.org/c/libosmo-abis/+/19256/3/include/osmocom/abis/e1_input.h@251 
PS3, Line 251: const char *use
> I am still not sure if you can selectively break this API. […]
If you know of any program (be it osmocom or not) using this API, I'm happy to lose time and efforts creating a new API with it, otherwise I see no point in doing so.


https://gerrit.osmocom.org/c/libosmo-abis/+/19256/3/src/e1_input.c 
File src/e1_input.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/19256/3/src/e1_input.c@378 
PS3, Line 378: Line (%p)
> Do we really need to print pointer address here? It makes the output non-deterministic. […]
It's still really useful to see the pointer, it's a quick way to identify line, specially since we keep around sometimes dummy lines temporarily. I can tell you, I have been debugging this for hours and it's useful.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19256
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I0658b2e9c452598025cc0f1d0b060076171767cc
Gerrit-Change-Number: 19256
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 15 Jul 2020 14:53:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200715/acce5b48/attachment.htm>


More information about the gerrit-log mailing list