This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/19256 ) Change subject: e1_input: Use osmo_use_count in e1inp_line ...................................................................... Patch Set 3: (4 comments) https://gerrit.osmocom.org/c/libosmo-abis/+/19256/3/TODO-RELEASE File TODO-RELEASE: https://gerrit.osmocom.org/c/libosmo-abis/+/19256/3/TODO-RELEASE@12 PS3, Line 12: libosmo-abis API change major: add parameter to struct lapd_instance If you're still planning to break the API, please reflect this breakage here. https://gerrit.osmocom.org/c/libosmo-abis/+/19256/3/include/osmocom/abis/e1_input.h File include/osmocom/abis/e1_input.h: https://gerrit.osmocom.org/c/libosmo-abis/+/19256/3/include/osmocom/abis/e1_input.h@195 PS3, Line 195: refcnt I think OSMO_DEPRECATED() could be used here too, but AFAIK only clang wold print a warning, while gcc would just ignore it. https://gerrit.osmocom.org/c/libosmo-abis/+/19256/3/include/osmocom/abis/e1_input.h@251 PS3, Line 251: const char *use I am still not sure if you can selectively break this API. I see that Osmocom programs are not using it, but what if some non-Osmocom program does? Would it be enough to keep it as is and use __func__ inside the function? https://gerrit.osmocom.org/c/libosmo-abis/+/19256/3/src/e1_input.c File src/e1_input.c: https://gerrit.osmocom.org/c/libosmo-abis/+/19256/3/src/e1_input.c@378 PS3, Line 378: Line (%p) Do we really need to print pointer address here? It makes the output non-deterministic. And in general, I thought the reference count changes are logged by the refcount API, or not? -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/19256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I0658b2e9c452598025cc0f1d0b060076171767cc Gerrit-Change-Number: 19256 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Wed, 15 Jul 2020 14:48:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200715/96244b20/attachment.htm>