Change in osmo-ttcn3-hacks[master]: bsc: test RR Channel Release EARFCNs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Jul 14 09:56:54 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216 )

Change subject: bsc: test RR Channel Release EARFCNs
......................................................................


Patch Set 1:

(5 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn 
File library/GSM_RR_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1074 
PS1, Line 1074: CellSelectionIndicatorValue
> looking around this file the style seems to be shortened names. so ok.

Yeah, please keep them short.

> but there's also something to using the exact naming from the specs...

Better add the spec. references in comments.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1087 
PS1, Line 1087: CellSelectionIndicatorValueEnum
> I see only this one. […]
Well, for sure it's not really important. But still improves readability. If it's private, I know that I can change it in any way and there are no potentially broken dependencies. This also speeds up rebuilding the test suite. Without 'private', if you change this definition, TITAN would rebuild all modules that implicitly import it, even if they don't actually use it.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1109 
PS1, Line 1109: arfcn
> in the spec this is called "FDD-ARFCN" and "TDD-ARFCN" -- i noticed that FDD and TDD are exactly the […]
Not critical, we can leave it as is. In the end, it's still ARFCN regardless of the network generation it relates to.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1134 
PS1, Line 1134: target_pcid
> 44.018 says […]
Ok, sorry for confusion. Indeed it seems to be a different IE.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1159 
PS1, Line 1159: meas_bw_presence := ?,
The problem is that this field is unconditionally set to '?', so your template parameter does not affect it. You don't really need this argument because you can explicitly pass 'meas_bw := omit' if it is expected to be absent.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I882c5e1f70bcc4833fc837a95c900ce291919cc5
Gerrit-Change-Number: 19216
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Tue, 14 Jul 2020 09:56:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200714/420be5e1/attachment.htm>


More information about the gerrit-log mailing list