Change in osmo-ttcn3-hacks[master]: bsc: test RR Channel Release EARFCNs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Mon Jul 13 11:27:41 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216 )

Change subject: bsc: test RR Channel Release EARFCNs
......................................................................


Patch Set 1:

(7 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/bsc/BSC_Tests.ttcn 
File bsc/BSC_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/bsc/BSC_Tests.ttcn@1825 
PS1, Line 1825: 		cells[i] := tr_CellSelectionIndicatorValue_EUTRAN_Description(earfcn, meas_bw_presence := '0'B, meas_bw := omit);
I am using meas_bw_presence here.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn 
File library/GSM_RR_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1074 
PS1, Line 1074: CellSelectionIndicatorValue
> It makes sense to shorten names a bit, e.g. CellSelIndValue.
yes, the names are getting awfully long, but there's also something to using the exact naming from the specs...
looking around this file the style seems to be shortened names. so ok.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1087 
PS1, Line 1087: CellSelectionIndicatorValueEnum
> Not sure if this type is going to be used outside, so let's make it 'private'. […]
I see only this one. But I wonder why keeping it private is worth spending thoughts on?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1109 
PS1, Line 1109: arfcn
> uarfcn?
in the spec this is called "FDD-ARFCN" and "TDD-ARFCN" -- i noticed that FDD and TDD are exactly the same structure, so i stripped the prefix and used this twice in the Enum above. It makes sense to add a 'u' but I try to use naming identical to the specs. What do you think?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1131 
PS1, Line 1131: define not_allowed_cells
> See GSM_RestOctets.EUTRAN_RepeatedNotAllowedCells (incomplete implementation).
indeed seems to be the same "PCID Group IE" coding


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1134 
PS1, Line 1134: target_pcid
> Can we use GSM_RestOctets. […]
44.018 says

 PCID to TA mapping : < PCID Group IE >

vs

 TARGET_PCID : bit (9)

so looks distinct to me...?
let's just leave it until someone wants to use it?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216/1/library/GSM_RR_Types.ttcn@1154 
PS1, Line 1154: meas_bw_presence
> Unused argument. I don't think it's even needed.
if i want to verify that the presence bit is encoded correctly, then I do need this argument.
I am using it in this patch.

Are you saying the presence bit is validated even when I am passing it as '?'



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19216
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I882c5e1f70bcc4833fc837a95c900ce291919cc5
Gerrit-Change-Number: 19216
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 13 Jul 2020 11:27:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200713/949579f8/attachment.htm>


More information about the gerrit-log mailing list