This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19124 ) Change subject: Move struct gsm_bts_trx: gsm_data.* & bts.* => trx.* ...................................................................... Patch Set 2: Code-Review-1 I'm also not entirely happy with this 'fragmentation'. But what I find even more problematic is the use of the generic term 'trx' which can mean a ton of d iffernt things, including being misunderstood as relted to osmo-bts-trx [only]. The idea about gsm_data*.h was that the core data model of bts/trx/ts/lchan is all represented there. Now if you think it is wise to split this (I think it's probably more annoying as it means you have to add more #includes to all files), then I think at the very least the header files should be called gsm_data_{bts,trx,...}.h to clearly indicate what they are about. You might also call them like the core struct they are about like gsm_bts.h gsm_bts_trx.h, ... but just 'trx' is really too easy to get wrong. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iebaf5b221c48b571f45408af867ce6f9c0cd9f4a Gerrit-Change-Number: 19124 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Wed, 08 Jul 2020 15:24:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200708/339c078b/attachment.htm>