Change in osmo-bts[master]: Move struct gsm_bts_trx: gsm_data.* & bts.* => trx.*

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Jul 3 22:40:52 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/19124 )

Change subject: Move struct gsm_bts_trx: gsm_data.* & bts.* => trx.*
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> Not sure if we really want to fragment the code/headers further... What's next, ts.h? lchan.h? I am fine with having everything here, in 'gsm_data.h', but if you really need this split up for the upcoming features, I can add CR+1. For now I am not convinced, sorry.

Yes, next is lchan.h and timeslot.h
We already have similar stuff in osmo-bsc and we actually have already an lchan.c with some functions defined in gsm_data.h in this same repository.

Code is growing in size over time and if we don't organize this we are adding stuff in random places with no logic and it's already a mess, it will become even worse over time.
I really want to clean up as much of possible out of gsm_data.{c,h}, since I think it disturbs more than helps in maintenance of code.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/19124
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iebaf5b221c48b571f45408af867ce6f9c0cd9f4a
Gerrit-Change-Number: 19124
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Fri, 03 Jul 2020 22:40:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200703/724296c3/attachment.htm>


More information about the gerrit-log mailing list