This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/19120 ) Change subject: mgcp_test: do not access endpoint array elements directly ...................................................................... Patch Set 2: Code-Review+1 (4 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/19120/2/tests/mgcp/mgcp_test.c File tests/mgcp/mgcp_test.c: https://gerrit.osmocom.org/c/osmo-mgw/+/19120/2/tests/mgcp/mgcp_test.c@610 PS2, Line 610: strcpy(last_endpoint, trunk->endpoints[i]->name); to copy entire strings always use OSMO_STRLCPY_ARRAY(...) or osmo_strlcpy() https://gerrit.osmocom.org/c/osmo-mgw/+/19120/2/tests/mgcp/mgcp_test.c@826 PS2, Line 826: endp = mgcp_endp_by_name(NULL, last_endpoint, cfg); OSMO_ASSERT(endp); https://gerrit.osmocom.org/c/osmo-mgw/+/19120/2/tests/mgcp/mgcp_test.c@882 PS2, Line 882: endp = mgcp_endp_by_name(NULL, last_endpoint, cfg); OSMO_ASSERT(endp); or actually, seems like this endp is not used at all? The next loop iteration is a separate test, so it uses a different endp anyway, right? https://gerrit.osmocom.org/c/osmo-mgw/+/19120/2/tests/mgcp/mgcp_test.c@1414 PS2, Line 1414: endp = mgcp_endp_by_name(NULL, last_endpoint, cfg); OSMO_ASSERT(endp); (...some more below) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/19120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ic950c427f23be4a792af94972554637c2b0fbdf2 Gerrit-Change-Number: 19120 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 06 Jul 2020 13:45:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200706/11042af9/attachment.htm>