<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19120">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19120/2/tests/mgcp/mgcp_test.c">File tests/mgcp/mgcp_test.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19120/2/tests/mgcp/mgcp_test.c@610">Patch Set #2, Line 610:</a> <code style="font-family:monospace,monospace">                       strcpy(last_endpoint, trunk->endpoints[i]->name);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">to copy entire strings always use OSMO_STRLCPY_ARRAY(...) or osmo_strlcpy()</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19120/2/tests/mgcp/mgcp_test.c@826">Patch Set #2, Line 826:</a> <code style="font-family:monospace,monospace">                 endp = mgcp_endp_by_name(NULL, last_endpoint, cfg);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">OSMO_ASSERT(endp);</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19120/2/tests/mgcp/mgcp_test.c@882">Patch Set #2, Line 882:</a> <code style="font-family:monospace,monospace">                      endp = mgcp_endp_by_name(NULL, last_endpoint, cfg);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">OSMO_ASSERT(endp);</p><p style="white-space: pre-wrap; word-wrap: break-word;">or actually, seems like this endp is not used at all?<br>The next loop iteration is a separate test, so it uses a different endp anyway, right?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19120/2/tests/mgcp/mgcp_test.c@1414">Patch Set #2, Line 1414:</a> <code style="font-family:monospace,monospace">    endp = mgcp_endp_by_name(NULL, last_endpoint, cfg);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">OSMO_ASSERT(endp);<br>(...some more below)</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/19120">change 19120</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/19120"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic950c427f23be4a792af94972554637c2b0fbdf2 </div>
<div style="display:none"> Gerrit-Change-Number: 19120 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 06 Jul 2020 13:45:11 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>